Installer step 2 - Indicate missing directories
Submitted by msauter on Sat, 07/14/2007 - 19:30.
| Project: | ProjectPier |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch - code needs review |
Description
The installer does not distinguish between directories/files which are not writable and directories/files which do not exist at all. The error message is always the same: "Error: XXX is not writable" I’d prefer the installer telling me "Error: /cache does not exist" if that’s the case.
I closed that issue because it is a duplicate to http://www.projectpier.org/node/96. I added a comment there to improve the error message.
- Roland
I'm re-opening this bug as it was marked as a dupe of #96, which I just closed, however bug #101 isn't exactly a dupe of #96, just related.
I'm attaching a patch to fix bug #101. See:
Index: ChecksStep.class.php
===================================================================
--- ChecksStep.class.php (revision 145)
+++ ChecksStep.class.php (working copy)
@@ -77,6 +77,12 @@
foreach ($this->check_is_writable as $relative_folder_path) {
$check_this = INSTALLATION_PATH . $relative_folder_path;
+ if (!file_exists($check_this)) {
+ $this->addToChecklist("$relative_folder_path does not exist", false);
+ $all_ok = false;
+ continue;
+ }
+
$is_writable = false;
if (is_file($check_this)) {
$is_writable = file_is_writable($check_this);