| Project: | ProjectPier |
| Version: | 0.8.5.0-Beta1 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Tim |
| Status: | closed - fixed |
Description
Sorry to submit again - last one truncated important parts of the message.
The RSS feed is only creating title, link, author and pubdate elements, not the description element for each item.
In future please add a comment to the issue instead of reposting it.
I don't think the RSS feed is supposed to create the description element, but I'll check anyway just to make sure.
Alex
Yep, the feed is not supposed to create the description element in the feed as the application logs do not generate one.
A good thing to do would be modify the application logs so that they also accept a content / description field.
Sorry about the repost - I was looking for an edit option - didn't think about a comment.
Thanks for the follow-up, but I am curious if the feed is not meant to have a description (which I am sure goes against the whole point of having a feed in the first place - ie so you can read the item from your feed reader without having to go to the website), then why does Angie_Feed_Renderer_RSS2.class.php contain these lines:
if ($description = trim($feed->getDescription())) {
$result .= '<description>' . clean($description) . "</description>\n";
}
Are there certain feed items that will actually display a description?
For some annoying reason you can't edit the original post in an issue, only comments on the issue (which is a little pointless in my opinion)
The Angie feed classes are part of a library which ProjectPier uses to generate feeds.
If you look in FeedController.php you can see that the description field is hard coded as '' (line 216).
Sorry, the Library is not 3rd party - it was developed for activecollab.
Here is a patch that is a start to add descriptions to the RSS feed.
For each object, it will use a template file to know how to display the information relative to that object.
At the moment, I haven't written all these files, but it will come.
For example, I'd like to show the full list of tasks when a task list is added.
For the files, I think it could put the content of .txt files and the thumbnail for an image file.
Another thing I want to do is check if an object has already been put in the feed not to repeat it. For example, if you add a comment and edit it later, both actions will appear in the feed and the same content will be displayed twice: the text for the addition won't be the text originally added but the text that was edited later. For the oldest actions, it should say that it has been modified in between with a link to the latest version.
If you want to try it or review it, please go ahead, it should work at the moment. It will add messages and comments, the rest is the same as the current situation.
At the moment, I haven't written all these files, but it will come.
What functionality is missing as a result of all the files not being in this patch?
I'm mostly concerned about picking of the body of messages in the RSS feed.
Thanks!
The patch above adds the body of messages and comments to the feed so you should give it a try!
I still need to get around to put the patch with other types of objects...
Your feedback would be greatly appreciated!
Thanks.
Accepted into 0.8.6