Transparent PNGs

Project:ProjectPier
Version:0.8.0.3
Component:Code
Category:bug report
Priority:normal
Assigned:phpfreak
Status:closed - fixed
Description

I noticed that when I uploaded a PNG for a company logo that had transparency, the transparency would be replaced by a solid dark color. Not cool.

#1

This patch solves the transparency issue with the PNGs.

AttachmentSize
transparent_png.patch 3.78 KB
#2

This patch is more precisely in line with the coding standards. (A couple tabs snuck into the last one).

AttachmentSize
transparent_png2.patch 3.8 KB
#3
Status:patch - code needs work» patch - code needs review

thx - can someone test this ?

#4
Status:patch - code needs review» patch - code needs work

Patch doesn't fail on current trunk but the bug persists. A transparent PNG still results in a black image.

Doesn't follow code standards but can easily be corrected.

#5
Assigned to:Visitor» phpfreak
Status:patch - code needs work» closed - fixed

Fixed in 0.8.6 for 32 and 64 bit RGBA PNG (rgb*) with or without background color. 8 bit PNG (pal) works partially. Test images came from this site :

http://entropymine.com/jason/testbed/pngtrans/

and are also attached.

AttachmentSize
pal.png 1.11 KB
pal_bk.png 1.13 KB
rgba8.png 270 bytes
rgba8_bk.png 288 bytes
rgba16_bk.png 336 bytes