Home :: Projects :: ProjectPier Project :: ProjectPier :: Issues

GUI UPDATES Page Actions as Inner Tabs (Rechecked)

By GameGod - Posted on November 25th, 2008
Project:ProjectPier
Version:0.8.5.0-Beta1
Component:User interface
Category:task
Priority:normal
Assigned:phpfreak
Status:closed - fixed
Description

I'm going through several GUI updates and will be prefixing my patches with that name.
Addresses: http://www.projectpier.org/node/1216

On the four views (dash,account,admin,project) the page actions are oddly placed and add to slight confusion in navigation throughout the website. That issue makes a very good point in that simply relocating it under the breadcrumb bar can help both asthetically and in locating the functions (for visibility and logical navigation).

I have added a wrapper in keeping of the style for tabs and copied all the css for tabs and applied it to the page actions, except for a minor fix on the borders. They instantly work and stand out as looking much improved than before. I have attached a screenshot of the effect (without hover). The dom is also a bit more semantic than that mentioned in the above issue (actionWrapper + located just below breadcrumbs wrapper)

The css changes are only for the default theme, however I expect when we/I develope the new core.css this will be included and less of a problem.

Please excuse the removal of js files mentioned in the patch, that's part of my conversion to jquery and could not figure out how to remove it from the patch file.

AttachmentSize
GUI UPDATES Page Actions as Inner Tabs.patch9.92 KB
GUI UPDATES Page Actions as Inner Tabs.JPG41.29 KB
#1
Submitted by kprobbins on Wed, 11/26/2008 - 19:31.

Cheers!

#2
Submitted by GameGod on Sun, 01/11/2009 - 02:54.

Cleaner/Checked patch file attached (removed wrong changes)

I Created a fresh install and tested this patch out. Went through the code and made sure the patch is a correct patch (as I was new to svn and had messed up some patches).

This patch I rechecked fresh and tested and DOES work however the css correction is only applied to the DEFAULT theme. The css will need to be replicated for other themes.

Affected Files:
application/layouts/account.php
application/layouts/administration.php
application/layouts/dashboard.php
application/layouts/project_website.php
public/assets/themes/default/stylesheets/general/construction.css

#3
Submitted by GameGod on Sun, 01/11/2009 - 02:55.
Title:GUI UPDATES Page Actions as Inner Tabs» GUI UPDATES Page Actions as Inner Tabs (Rechecked)
#4
Submitted by TheWalrus on Thu, 01/22/2009 - 21:27.

I like this patch a lot. I do have one improvement: move the pageActionsWrapper DIV element inside the outerContentWrapper DIV element. Many themes have a background applied to the outerContentWrapper DIV that is designed to start immediately beneath the crumbsWrapper DIV.

I have done this (and added a "clear: both" line to the #innerContentWrapper in construction.css) and attached a patch below.

#5
Submitted by phpfreak on Thu, 11/11/2010 - 23:08.
Assigned to:Visitor» phpfreak
Status:patch - code needs review» closed - fixed

Last patch by TheWalrus is in 0.8.6