| Project: | ProjectPier |
| Version: | 0.8.0.3 |
| Component: | Miscellaneous |
| Category: | feature request |
| Priority: | normal |
| Assigned: | erbag |
| Status: | patch - code needs work |
Description
A fully functional WYSIWYG Editor. The features of the WYSIWYG Editor includes:
- Bold
- Italics
- Underline
- Defines & Undefined Lists
- Superscript
- Subscript
- Blockquote
- Font Size
- Font Format
- Font Colour
- Hyperlinks (text)
- HTML View
Credit:
--------------------------------------------
nicEdit by Brian Kirchoff
"Adding TinyMCE..." posted by Matt Gibson
Implemented by Gabre Cameron of Pxl Junkie
*** E-mail notifications are also sent in HTML format.***
| Attachment | Size |
|---|---|
| wysiwyg_v1-2.zip | 81.52 KB |
Thank you for your contribution! I haven't looked at this yet, but I'm wondering if it has been implemented as an option that the system administrator can turn on and off?
Could you also explain a little bit about compatibility with an existing database for those who upgrade an existing installation. Are there any ill effects when editing existing data?
Thanks!!
Jon
Hi:
I added WYSIWYG editor and it works perfect on FireFox.
However, the editor is squeezed on IE 6 & IE 7 while adding comments to messages.
Can you let us know how this can be fixed.
Thanks!
Two problems that I can see:
1) You did not submit this as a .patch (diff) file. Unfortunately, it will never be accepted until you (or someone else) submits this as a .patch file created with the 'diff' utility.
2) The license explicitly forbids all commercial use. ProjectPier is used by commercial organizations, so anything accepted into the core would likely have to be licensed as such. I think if the license were changed to disallow selling of the code, that would be fine. Alternatively, implement this as a plugin. Unfortunately, plugin support is not yet accepted into core (because it is quite a hack at the moment).
@ TheWalrus: I'm really a designer not a programmer and I read how to make a patch and none of it made sense to me. Sorry!
@ Mann: I will look if there is a way to fix the IE7 issue.
@Jon: I've not noticed any negative effects of by DB since I did this to my instillation of ProjectPier.
Hi,
I have done a diff for WYSIWYG Editor v1.2 against PP v.0.8.0.3.
See attached file.
At first, thanks for your work!!!
Version 1.2 of this patch is english only.
I have changed 1 file to make it language independent.
Also added support for time managment patch posted at this site.
Just replace with this new file from attach.
PS.
Do not supported text fields:
* at Add/Edit Form field with id='projectFormSuccessMessage'
* at Tasks page fields for adding new task in each task list.
That sounds real good
Added 'edit task' form. This means that when you edit task you will see this editor.
'fontSize' is called twice.
Below is a patch.
new nicEditor({buttonList : ['bold','italic','underline','ol', 'ul','strikeThrough','subscript','superscript','indent','outdent','fontSize','fontFamily','fontFormat','forecolor','image','link','xhtml']}).panelInstance('".$textareaID."');
...
new nicEditor({buttonList : ['bold','italic','underline','ol', 'ul','strikeThrough','subscript','superscript','indent','outdent','fontSize','fontFamily','fontFormat','forecolor','image','link','xhtml']}).panelInstance('".$textareaID2."');
If you noticed, I also added 'image'.
I'd rather not allow changing the font size of messages so in my attached file, 'fontSize' was never called.
>>The license explicitly forbids all commercial use.
I thought TinyMCE was licensed under the LGPL, which should allow it to be used in both free and non-free software and for any use, right?
@Jon: You changed the issue title. Don't do that. :D I've changed it back.
As for the licensing issue, this is "nicEdit" and not "TinyMCE" and the license.pdf distributed in the original ZIP file explicitly says: "Noncommercial. You may not use this work for commercial purposes."
Along those lines, the patch attached by @VladSavitsky is incomplete (and legally dangerous) in so far as it does not retain the license. It also contains some weird characters at the beginning of some of the lines. Therefore, I've changes the issue status to "patch - code needs work".
If someone wants to contact the original ZIP file author, and the "nicEdit" people and get them to relicense it to LGPL, that would be great.
Guys I must apologize for my delay in addressing some of the issues. I a few weeks I'll take in consideration all the issues and release a 1.3 which will allow you to use as long as credit is give...
Blessings!
Bug report: <p> is generated inside <pre>
When I post a message contained in pre tag:
1: | //foo bar2: |
3: | //this line should display after 2 <br>
the sample message above displays like this one below:
1: | //foo bar2: |
3: |
4: | //this line should display after 2 <br>
Noticed the extra-line?
When I view-source it, a <p> tag is causing the extra line.
Though, I suspect this is caused by ProjectPier and not the nicEdit.
...looks like the error is from Textile.class.php
VladSavitsky how did you know to add case lang('add project'): instead of what I used? Where can I find full documentation on the language file?
There is a v1.3 that's now out that address the issues you've discussed here and the GOOD NEWS is you can use it COMMERCIALLY.
GET ProjectPier WYSIWYG Editor version 1.3 NOW!
After four hours following all these instructions I've been unable to see the WYSIWYG editor, though I was able to install Textile.
My assumption was that the initial download http://www.projectpier.org/files/issues/wysiwyg_v1-2.zip would be updated by the developer to include all the patches, as on Drupal. Is that true, or must these all be applied in sequence?
Also, I'm noticing the path
<?phpinclude_once('public/assets/wysiwyg/inc/nicEdit.inc')
?>
although complete paths from the PP root directory are not used for other js (e.g.
<?phpecho add_javascript_to_page('app.js')
?>
). Could that be an issue?
- Bram-at-gamefacewebdesign.com
Firstly I'd like to thank you for making this rad feature! It is really helping out my organisation heaps.
Just wondering if there is any documentation on how to integrate this into other areas of the code so that it can be integrated with the Wiki patch and Task descriptions themselves.
Also, for what it's worth I turned on debug the other day to solve a different problem and noticed "Notice: Undefined variable: form in --snip--/public/assets/wysiwyg/inc/nicEdit.inc on line 96"
It's probably not a serious problem but figured I'd bring it to your attention.
Cheers,
Shane