Wiki edit dialog buttons

Project:ProjectPier
Version:0.8.6-stable
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:new
Description

When you edit a wiki page, the save page button at the bottom right is labelled "Edit Page". It should be labelled "Save Page".

There should probably also be a "Cancel" or "Revert" button.

#1

You can change the label yourself in file

/application/plugins/wiki/language/en_us/wiki.php

Look for this:

'add wiki page' => 'Add page',
'delete wiki page' => 'Delete page',
'edit wiki page' => 'Edit page',

The Cancel link should have been there. Now you have to click the name of the page in the action bar.

#2

Just to be clear: I didn't mean the action links at the top, but the button below the text entry field when you're already editing the page. It says "Edit Page" but it's the button you click when you're done editing.

#3

Yes. If you would change 'Edit page' into 'Save' you would see the difference.

#4

I don't actually have access to the application to try this out. But looking at /application/plugins/wiki/views/edit.php on SVN, the same localized string is used for the breadcrumbs, the action bar, and for the submit button on the edit form. But in the breadcrumbs/action bar is *should* say "add page", but the SUBMIT button should not (when it's displayed, you're already editing the page, and clicking it doesn't edit the page, but SAVE the page). So you need a NEW localized string in /application/plugins/wiki/language/en_us/wiki.php

'save wiki page' => 'Save page',

and line 52 of /application/plugins/wiki/views/edit.php should be changed from

<?php
echo submit_button($page->isNew() ? lang('add wiki page') : lang('edit wiki page'))
?>

to

<?php
echo submit_button($page->isNew() ? lang('add wiki page') : lang('save wiki page'))
?>