Home :: Projects :: ProjectPier Project :: ProjectPier :: Issues

Comments on private tasks should not generate notifications for clients.

By mightyulysses - Posted on February 9th, 2011
Project:ProjectPier
Version:0.8.6-stable
Component:Code
Category:bug report
Priority:normal
Assigned:phpfreak
Status:closed - fixed
Description

Comments on private tasks should not generate notifications for clients.

#1
Submitted by phpfreak on Wed, 02/09/2011 - 22:53.
Assigned to:Visitor» phpfreak
Status:new» patch - code needs review

I guess this could do the trick:

File /application/models/notifier/Notifier.class.php

        if ($comment->isPrivate()) {

becomes

        if ($comment->isPrivate() || $comment->getObject()->isPrivate()) {
#2
Submitted by mightyulysses on Fri, 02/11/2011 - 20:22.
#3
Submitted by rzelnik on Fri, 02/18/2011 - 16:56.

There are two occurrences of that line. Which one do you mean? (lines 261 or 396)

#4
Submitted by monachus on Mon, 05/02/2011 - 14:42.

We reviewed the code and decided that patching both of the locations was the best. One is only rarely used, but there didn't seem to be a reason to leave it unchanged. Patchfile attached.

AttachmentSize
2166.patch 967 bytes
#5
Submitted by phpfreak on Wed, 05/11/2011 - 08:49.
Status:patch - code needs review» closed - fixed

Added to 0.8.7

#8
Submitted by phpfreak on Thu, 09/01/2011 - 07:34.
Title:Comment on a private tasks notifies clients» Comments on private tasks should not generate notifications for clients.