| Project: | ProjectPier |
| Version: | 0.8.0.2 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | miknight |
| Status: | closed - by issue author |
Jump to:
Description
I noticed that sometimes recipient is spelled recepient. And that is in the code and in the translations.
Since it's all over the place, I'm not sure how to provide a patch. A "Replace All" should be done before the next release, maybe?
I have no idea if the mispelling causes any problems anywhere though.
Yes, I've noticed this myself and started work on fixing it all up, along with a bunch of other typos. There are quite a lot! :P
This should be done as part any code clean up for the next release. It will need to be completed before the "string freeze" for translators to upgrade their files with.
In the meantime, we *could* fix the english translation files in the actual strings, but we can't fix the coded strings, since that would break all the 0.8.0.x translations.
Also, I am not sure this will warrant a new release (e.g. 0.8.0.1) on its own - but it could be rolled into a new release if we make any security patches or otherwise find a reason to release a new update.
Fixed with 0.8.0.2 and patch that you can find at http://projectpier.org/node/721#comment-332
I might as well fix the title for good measure
Not sure why this hasn't been corrected, here's a report of the files the misspellings show up in, in case you're like me and don't have a clue about version control.
Fix all of these occurences (11 occurrences in 3 pages) from recepient to recipient:
Page Line Matched Text
/projectpier-0.8.0.2/application/models/notifier/Notifier.class.php [1/8] 1 $recepients = array();
/projectpier-0.8.0.2/application/models/notifier/Notifier.class.php [2/8] 1 $recepients[] = self::prepareEmailAddress($user->getEmail(),...
/projectpier-0.8.0.2/application/models/notifier/Notifier.class.php [3/8] 1 $recepients,
/projectpier-0.8.0.2/application/models/notifier/Notifier.class.php [4/8] 1 $recepients = array();
/projectpier-0.8.0.2/application/models/notifier/Notifier.class.php [5/8] 1 $recepients[] = self::prepareEmailAddress($subscriber->getEmail(),...
/projectpier-0.8.0.2/application/models/notifier/Notifier.class.php [6/8] 1 $recepients[] = self::prepareEmailAddress($subscriber->getEmail(),...
/projectpier-0.8.0.2/application/models/notifier/Notifier.class.php [7/8] 1 if (!count($recepients)) {
/projectpier-0.8.0.2/application/models/notifier/Notifier.class.php [8/8] 1 return true; // no recepients
/projectpier-0.8.0.2/language/en_us/errors.php [1/1] 1 'massmailer select recepients' => 'Please select users that will receive this email',
/projectpier-0.8.0.2/language/en_us/site_interface.php [1/2] 1 'test mail recepient' => 'Test recepient',
/projectpier-0.8.0.2/language/en_us/site_interface.php [2/2] 1 'test mail recepient' => 'Test recepient',
Here's a link to the report, maybe easier to read:
http://liveblog.crssp.com/BlogEngine/post/Patches-for-ProjectPier-Recepient-Mispelling.aspx
The indifference to long-standing misspellings in the code, have me wondering if the projectPier will be a professional quality endeavor anytime in the future?
My email notifications to recepients recipients is very buggy, not getting notifications even though the test mailer is working.