Email notifications... Correct task assigned file

Project:ProjectPier
Version:0.8.5.0-Beta1
Component:Code
Category:feature request
Priority:normal
Assigned:phpuser
Status:closed - duplicate
Description

I think it is almost a necessity for the Software to have A LOT more email notifications. Can we introduce a feature where users in the system get email updates for task assignments and when there are updates to tasks assigned to them?

#1

In particular, when a user is assigned a task by another user, an email should be sent. Otherwise, unless they are actively checking "My Projects" they may not be aware of the assignment. (And, even if they are, if the list is long, they might not notice :-)

#2

I agree, this would be a very useful feature. Being able to add comments/follow up to a specific task would not be too shabby either.

#3

I thrid that!

#4
Status:new» open - needs more info
#5
Version:<none>» 0.8.0.2
Component:User interface» Code
Assigned to:Visitor» phpuser
Status:open - needs more info» patch - code needs review

Task Notification checkbox added to every place a user can be assigned effected by a task (adding/editing tasks, adding task lists).

Task notifications handled the same way Milestone notifications are handled. They are only sent if the user logged in is NOT the user the task is being assigned to (already assigned to).

Patch attached.

AttachmentSize
email_notifications.patch 13.59 KB
#6

I'm testing the patch and it's working fine for me.

The only thing I saw that is missing is the template file for task_assign that must be created.

File: (application\views\notifier\task_assigned.php)

#7
Title:Email notifications...» This is a duplicate - patch already posted

http://www.projectpier.org/node/950

Not sure which one is better ...

#8
Title:This is a duplicate - patch already posted» Email notifications...

Do not change the title because of a duplicate.
You should change the status to "closed - duplicate" instead.

#9

hey phpuser,

I tried Applying your patch, everything went decently smooth, but I get the errors: Missing lang: send assigned to notification almost everywhere.

Is there another file that I am missing?

The patch included changes to:

emails.php
project_interface.php
notifier.class.php
VersionsFeed.class.php
TaskController.class.php
add_milestone.php
add_task.php
task_list.php
add_list.php

---

emails.php and notifier.class.php gave an unexpected error saying that the version is older than the current. I am current using version 0.8.0.3.

---

Not sure if anyone else is having this same problem?

#10

Added this patch. Got everything to work except task notification. Can't get it to work for the life of me. I went line by line through the patch file and manually checked each file to make sure that they matched....

They did and still no task notification.

#11

Nice patch!

Here's the missing /application/views/task_assigned.php that I created.

------------------------------------------------------------
<?php echo lang('dont reply wraning') ?>
------------------------------------------------------------

Company: <?php echo owner_company()->getName() ?>

Project: <?php echo $task_assigned->getProject()->getName() ?>

<?php echo lang('task assigned', $task_assigned->getProject()->getName()) ?>

by <?php echo $task->getCreatedBy()->getDisplayName(); ?> (<?php echo $task->getCreatedBy()->getEmail(); ?>):

<?php echo $task_list->getName(); ?>

  * <?php echo $task_assigned->getText(); ?>

    <?php echo str_replace('&amp;', '&', $task_assigned->getViewUrl()) ?>

--
<?php echo lang('view task list') ?>

<?php echo str_replace('&amp;', '&', $task_list->getViewUrl()) ?>

It mirrors Basecamp's to-do email. To make it more "Basecamp-like", modify your /language/en_us/emails.php strings and the subject lines in /application/models/notifier/Notifier.class.php.

Cheers!

#12

For 0.8.0.3, I had to change the $task_assigned->getViewUrl() call in the task_assigned.php file provided to $task_assigned->getObjectUrl().

#13
Version:0.8.0.2» 0.8.0.3

I tried applying this patch with Tortoise SVN and got the same two errors for
emails.php and notifier.class.php.

Wondering if/how anyone solved this problem?

Also, faren451 is there anything you had to modify in the patch with the new task_assigned.php file that was created?

Thanks

#14

No notification of the task when I applied the patch.

I tried $task_assigned->getViewUrl() and $task_assigned->getObjectUrl() in the task_assigned.php. None of them worked.

Anyone get successful with 0.8.0.3?

#15

Any upadated patch for 8.0.3 ?
or the current SVN trunck ?

#16
Title:Email notifications...» Email notifications... Correct task assigned file

OK, after struggling for a while, I figured out why I had a problem with the email notification on task assignment:
- there was indeed a missing Task_assigned.php file, the the one provided was not located correctly: it has to be placed in \application\views\notifier

- I reused the Milestone_assignated.php file as template to generate the attahced file.

With this, for me it works!

I´m still missing the tasks comments notification, but it's a different issue :-)

AttachmentSize
task_assigned.php_.txt 670 bytes
#17
Version:0.8.0.3» 0.8.5.0-Beta1
Status:patch - code needs review» closed - duplicate

http://www.projectpier.org/node/1198